Ticket #7 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Switching to/from msw/fsw with a dive planned leaves the last stop and step wrong.

Reported by: eskil Owned by: eskil
Priority: critical Milestone: Version 0.9.2
Component: Plan Settings Version: 0.9
Severity: Must Have Keywords:
Cc: Fixed in Version: 0.9.2

Description

If you have a dive plan set, and you change the units being used, the conversion leaves the number is a slightly off state due to rounding.

Ie. a plan for 160fsw with last stop at 20fsw and interval of 10fsw. If changed to msw will yield a dive to 51msw but with a last stop of 6.14msw and a step interval of 3.07msw.

Hence a decogas such as 100% at 20fsw becomes 100% at 6msw, but wont be picked at the last stop since 6msw < 6.14msw...

Luckily this generates a plan that is obviously suspicious since all deco gas switches are off by 1 stop. And if you start a clean plan with the unit system chosen, everything will be right.

And of course ditto if switching from msw to fsw with a plan already set.

Change History

Changed 10 years ago by eskil

  • status changed from new to accepted

Changed 10 years ago by eskil

I'll aim for displaying a warning to user if the unit system is being changed and there's a dive plan in place. And if the user ok's the change, make sure all the numbers are converted to the expected equivalents.

Changed 10 years ago by eskil

  • summary changed from Switching to/from msw/fsw with a dive leaves the last stop and step wrong. to Switching to/from msw/fsw with a dive planned leaves the last stop and step wrong.

Changed 10 years ago by eskil

  • milestone changed from Version 1.0 to Version 0.9.2

Changed 10 years ago by eskil

  • status changed from accepted to closed
  • resolution set to fixed

Fixed in change 720, 721, 722 and 732.

Changed 10 years ago by eskil

  • fixed_in_version set to 0.9.2
Note: See TracTickets for help on using tickets.